-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag versions and hugo modules #64
Comments
Good point @aljaznuncic. I have now finally released version 1.0.0 of hugo-shortcode-gallery. |
Go based tagging scheme requires trying It does, pulling the master commit. The tag won't work as I thought without using $ hugo mod get github.com/mfg92/hugo-shortcode-gallery@latest
go: downloading github.com/mfg92/hugo-shortcode-gallery v0.0.0-20231103123849-a02ed1699264
go: added github.com/mfg92/hugo-shortcode-gallery v0.0.0-20231103123849-a02ed1699264 |
I have added the "v", can you try again? |
Let's warm this up, I'm interested as well. I just tested it on my machine, but I have no experience with hugo modules so far. Here is what I did: Remove theme reference from my config. In my case that means removing the whole line
I also renamed the folder Adding hugo-shortcode-gallery as new item in module.imports
"Downloading" the module
Now, when I run
Running |
@josephbadow I have finally set up hugo-shortcode-gallery as a Hugo module. Could you please test it to ensure it works as expected? Although it worked on my end, it would be great to have another perspective :) I have created a release wit this change: v1.1.0 Feel free to share your thoughts on the updated README.md too. Thank you! |
I started by updating my modules (I think that command is currently missing in your readme) and that worked flawlessly. # Displaying currently installed modules
$ hugo mod graph
github.com/jpanther/congo github.com/jpanther/congo/[email protected]
github.com/jpanther/congo github.com/mfg92/[email protected]
# Updating modules
$ hugo mod get -u
go: downloading github.com/mfg92/hugo-shortcode-gallery v1.1.0
go: upgraded github.com/mfg92/hugo-shortcode-gallery v1.0.0 => v1.1.0
# Building pages
$ hugo
WARN Failed to read module config for "github.com/mfg92/hugo-shortcode-gallery" in "/home/joseph/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/mfg92/[email protected]/theme.toml": "_stream.toml:8:20": unmarshal failed: toml: float can have at most one decimal point
Start building sites …
hugo v0.122.0-b9a03bd59d5f71a529acb3e33f995e0ef332b3aa+extended linux/amd64 BuildDate=2024-01-26T15:54:24Z VendorInfo=snap:0.122.0
| EN
-------------------+------
Pages | 100
Paginator pages | 5
Non-page files | 31
Static files | 24
Processed images | 214
Aliases | 35
Sitemaps | 1
Cleaned | 0
Total in 449 ms I received a warning during build, which I saw at other points as well (gohugoio/hugo#11558, golang/go#61888). It doesn't affect my page and the one gallery I have is still behaving as expected. |
That warning is now fixed thanks to #69. |
I have incorporated your feedback about the readme in the latest commit. |
It will be very good, if we start versioning code with tags, so we can use this shortcode with hugo modules: https://gohugo.io/hugo-modules/use-modules/#get-a-specific-version
The text was updated successfully, but these errors were encountered: