Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to extend? #24

Open
jarvist opened this issue Aug 1, 2023 · 1 comment
Open

How to extend? #24

jarvist opened this issue Aug 1, 2023 · 1 comment

Comments

@jarvist
Copy link

jarvist commented Aug 1, 2023

Is there a preferred method / approach to extending this package?
In particular, I would a HDF5 reader for VASP, but I don't really know whether it makes most sense to write a (HDF.jl depending) function in AtomsIO.jl; or write a vasp_HDF5.jl package elsewhere and wrap here, or ... ?

@mfherbst
Copy link
Owner

mfherbst commented Aug 5, 2023

Great idea, thanks for getting in touch @jarvist.

To be honest I think both could make sense. I would say if it's just a few lines it might as well live here, since the code won't be of much other use anyway.

If you are worried about the HDF5 dependency ... we can always make it a package extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants