Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that popup=async + JavaScript allows custom behavior #7

Closed
domenic opened this issue Feb 23, 2022 · 1 comment
Closed

Note that popup=async + JavaScript allows custom behavior #7

domenic opened this issue Feb 23, 2022 · 1 comment

Comments

@domenic
Copy link

domenic commented Feb 23, 2022

This was a nice bonus I discovered upon reflection, and comparing with the old popup proposal.

If a developer wants some sort of custom behavior, e.g., "close all other toasts that are of a similar application-specific type", or "no force-close but yes light dismiss", then they can accomplish it using popup=async plus some custom JavaScript code for the entertoplayer handler.

This is good! It counters any arguments that, by providing somewhat-opinionated classes of UI, we're doing something too magic that will make developers sad.

I think this is worth pointing out in https://github.com/mfreed7/popup#classes-of-ui---dismiss-behavior-and-interactions .

(Also it may feed into the bikeshed discussion, e.g. popup=manual might be a better name than popup=async.)

@mfreed7
Copy link
Owner

mfreed7 commented Mar 16, 2022

Moved to here: openui/open-ui#495

@mfreed7 mfreed7 closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants