From 0df0507f0d63ad0c6df1b21ec2249516eb860af7 Mon Sep 17 00:00:00 2001 From: michaelfeil Date: Tue, 15 Oct 2024 19:18:10 -0700 Subject: [PATCH] add appendix tag in release ci --- .../pull_request_template.md | 24 ------------------- .../workflows/release_docker_container.yaml | 8 +++++-- 2 files changed, 6 insertions(+), 26 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md deleted file mode 100644 index 2044b70a..00000000 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ /dev/null @@ -1,24 +0,0 @@ -## Description -Please provide a clear and concise description of the changes in this PR. - -## Related Issue -If applicable, link the issue this PR addresses. - -## Types of Change -- [ ] Bug fix -- [ ] New feature -- [ ] Documentation update - -## Checklist -- [ ] I have read the [CONTRIBUTING](https://github.com/michaelfeil/infinity/tree/main?tab=readme-ov-file#contribute-and-develop) guidelines. -- [ ] My code follows the code style of this project. -- [ ] I have added tests to cover my changes. -- [ ] All new and existing tests passed. -- [ ] My changes generate no new warnings. -- [ ] I have updated the documentation accordingly. - -## Additional Notes -Add any other context about the PR here. - -## License -By submitting this PR, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/michaelfeil/infinity/blob/main/LICENSE). diff --git a/.github/workflows/release_docker_container.yaml b/.github/workflows/release_docker_container.yaml index d71e8039..1ac4aec7 100644 --- a/.github/workflows/release_docker_container.yaml +++ b/.github/workflows/release_docker_container.yaml @@ -29,6 +29,7 @@ on: env: TEST_TAG: ${{ inputs.image }}:test LATEST_TAG: ${{ inputs.image }}:latest + APPENDIX_TAG: ${{ inputs.appendix_tag || '' }} jobs: docker: @@ -67,6 +68,8 @@ jobs: with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} + + # Uncomment the following steps if you want to build and test the image locally # - name: Build for Test # uses: docker/build-push-action@v5 # with: @@ -74,6 +77,7 @@ jobs: # file: ${{ inputs.dockerfile }} # load: true # tags: ${{ env.TEST_TAG }} + # # - name: Test # # show that at least --help command is running # run: | @@ -88,5 +92,5 @@ jobs: # linux/amd64 and linux/arm64 # cache-from: type=registry,ref=${{ env.LATEST_TAG }} platforms: ${{ inputs.platforms }} - tags: ${{ env.LATEST_TAG }}{{ inputs.appendix_tag }},${{ env.VERSION_TAG }}{{ inputs.appendix_tag }} - push: true + tags: ${{ env.LATEST_TAG }}${{ env.APPENDIX_TAG }},${{ env.VERSION_TAG }}${{ env.APPENDIX_TAG }} + push: true \ No newline at end of file