Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding quantization #245

Closed
michaelfeil opened this issue Jun 6, 2024 · 5 comments
Closed

Embedding quantization #245

michaelfeil opened this issue Jun 6, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@michaelfeil
Copy link
Owner

Feature request

Quantization against:

Motivation

Your contribution

Looking for contributors to fill the blank of embedding quanitzation.

@cache 
def quantize_embedding_stats(model: str, dataset: some_dataset.parquet) -> statistics[min,max,median,other]:
      ...
      
def quanize_embeddings()
     quantize_embedding_stats()
@michaelfeil michaelfeil added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 6, 2024
@mahiro72
Copy link

mahiro72 commented Jun 7, 2024

Hello @michaelfeil , I'm interested in working on this issue. Can I give it a try?

@michaelfeil
Copy link
Owner Author

Actually started to implement a rough sketch! But then i continued working on it, and it might have solced it entirely. Want to give it a try? @mahiro72

@michaelfeil
Copy link
Owner Author

michaelfeil commented Jun 8, 2024

#247, Completed as a "v1"

@michaelfeil
Copy link
Owner Author

@mahiro72 moved it to here: #250

@mahiro72
Copy link

mahiro72 commented Jun 9, 2024

@michaelfeil
Thank you! I would like to work on this issue to verify the performance.
#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants