-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to upcoming Sphinx 2.0 #411
Conversation
372f3dd
to
7531eba
Compare
Thank you @jakobanderson this is really helpful! I was under the impression that we needed to switch to Does this supersede #410? |
I think the testing between the projects are completely independent, though from my limited understanding of Python tooling it may still be a good idea to switch to pytest at some point (the Sphinx PR for switching: sphinx-doc/sphinx#3302), I should probably have described the PR dependencies and their context:
|
Thanks a lot for all submitting all these patches. I have been rather busy for a while so my responses to Breathe-related things have been slow. PR #410 seems ok to me, so I'll merge it now. Indeed long term the plan for an eventual Breathe 5 is to rewrite and/or refactor major parts of the sometimes overly complex logic and let Sphinx itself handle things cleanly. As you said I am sure this will fix several open bugs and quirks. Thanks again! |
7531eba
to
22a8880
Compare
If you trigger a rebuild in Travis it should(TM) succeed now that Sphinx 2.0 has been released. |
Hi michaeljones, |
Doh, nevermind, 2.0 is close to be released, but it will take a few more weeks. |
@jakobandersen Can you push to trigger a build? |
Now I think the PR should be ready to merge :-) |
Looks good to me. Just to make sure: merge this and release as v4.13.0? |
I'm wondering if there is still an issue with this PR? I'm using it for a while and it works fine, it'd be nice to merge it and have a new version :-) If there is an issue, I'm happy to help btw. |
can we merge this ? |
I have released v4.13.0 containing this fix, all should be good now. |
@melvinvermeeren is it ready in pip ? |
@Milerius Should be up now, the upload was running at the time you posted. |
@melvinvermeeren Thank's a lot i made the upgrade |
Initial steps to adapt to the upcoming version of Sphinx (2.0).