Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license file to distribution #492

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Add license file to distribution #492

merged 1 commit into from
Apr 7, 2020

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Apr 6, 2020

No description provided.

@vermeeren vermeeren self-assigned this Apr 7, 2020
@vermeeren vermeeren added the enhancement Improvements, additions (also cosmetics) label Apr 7, 2020
@vermeeren vermeeren self-requested a review April 7, 2020 15:07
vermeeren
vermeeren requested changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the Please from the commit message (and patchset title).

@hmaarrfk hmaarrfk changed the title Please add license file to distribution Add license file to distribution Apr 7, 2020
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 7, 2020

done!

@vermeeren vermeeren merged commit 67401cd into breathe-doc:master Apr 7, 2020
@vermeeren
Copy link
Collaborator

Thanks for the patch, merged.

vermeeren added a commit that referenced this pull request Apr 7, 2020
@vermeeren
changelog: update for #492
33f2ef5
@hmaarrfk hmaarrfk deleted the patch-1 branch April 7, 2020 19:32
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 7, 2020

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermeeren vermeeren vermeeren approved these changes

Assignees

@vermeeren vermeeren

Labels
enhancement Improvements, additions (also cosmetics)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @vermeeren