Sphinx 3.4.x compatibility

[utzig]

Allows for running on 3.4.x series, and updates test matrix to add Python 3.9.0 and all minor Sphinx releases in the 3.x series as well as the development tag.

This fixes #612 and supersedes #615

@vermeeren I would suggest releasing 4.26.0 if possible.

[utzig]

@vermeeren Also worth mentioning that I tested with Python 3.9.0 and Sphinx 3.4.2 on my projects with no issues.

[jakobandersen]

LGTM

[vermeeren]

Added a missing update to requirements/production.txt just now, everything else looks good. Thanks @utzig !

[utzig]

Added a missing update to requirements/production.txt just now, everything else looks good. Thanks @utzig !

Btw, Sphinx==3.4.3 came out today, I didn't have time to test it, but I can do some testing and update the test matrix now (in the next 1 hour or so I hope).

[vermeeren]

@utzig Strange that CI complains now, from https://github.com/michaeljones/breathe/pull/617/checks?check_run_id=1665421730

Run make type-check
mypy breathe tests
breathe/path_handler.py:18: error: Argument 1 to "join" has incompatible type "Optional[str]"; expected "Union[str, _PathLike[str]]"
breathe/directives.py:592: error: Argument 1 to "join" has incompatible type "Optional[str]"; expected "Union[str, _PathLike[str]]"
Found 2 errors in 2 files (checked 28 source files)
make: *** [type-check] Error 1
Makefile:48: recipe for target 'type-check' failed
Error: Process completed with exit code 2.

Sphinx 3.4.3 changes very little, see sphinx-doc/sphinx@v3.4.2...v3.4.3 . Thoughts on fixing this? Can always do # type: ignore I suppose.

And yes, I'll be glad to wait for your next version in the hour or so. Thanks!

[utzig]

Sphinx 3.4.3 changes very little, see sphinx-doc/[email protected] . Thoughts on fixing this? Can always do # type: ignore I suppose.

Yeah, I fixed the mypy issues as you suggested; I guess it would be a good idea to understand why this happened, I can try to track it down tomorrow. But it works 100%, tested Sphinx==3.4.3 with the updated PR and it's all fine!

[vermeeren]

@utzig Thanks! I'll check it out and hopefully make a release tonight.

[jakobandersen]

Yeah, I fixed the mypy issues as you suggested; I guess it would be a good idea to understand why this happened

It looks like it is because of Sphinx.confdir which it thinks has type Optional[str]. However, after Sphinx.__init__() it can no longer be None so ignoring the type error seems reasonable to me.