Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #62 #63

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix for #62 #63

wants to merge 9 commits into from

Conversation

jonschlinkert
Copy link
Member

@jonschlinkert jonschlinkert commented Feb 23, 2020 •
edited
Loading

I'm leaving this PR open until I get everything fixed on micromatch and picomatch.

fixes #58

@jonschlinkert
fixes #62
2e56526 
as well as a few other minor optimizations and linting.
@jonschlinkert
Merge branch 'dev'
d64b291
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.893% when pulling d64b291 on fix-issue-62 into 66e1b20 on master.

@jonschlinkert
don't use negative lookbehind
eaab152
@jonschlinkert
improve coverage, lint
5d0c254
@jonschlinkert
fix tests
a49bb20 
For now, we're going to skip `nyc` with the github workflow, since it gives the appearance that tests are failing when we have less than 100% coverage. I'd like to have 100%, but we're close, and that's good enough for now.
@jonschlinkert
fix assert for 8.6
ad51b07
@jonschlinkert
fixes #57
dbe5d92 
fixes #60
fixes #61
@jonschlinkert
ensure tok.output is the same as tok.value when type is text
4157b78
@jonschlinkert
upgrade deps
850e970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The scan method returns empty parts for pattern with only a forward slash
1 participant
@jonschlinkert