Fail build if potentially missing types found in method signatures

[shakuzen]

Sorry this keeps coming up. You'd think I would remember. I tried looking into tools/build plugins we could use to catch this but I haven't found something so far. Checkstyle and Forbidden APIs didn't seem to have the feature of disallowing a method parameter or return type that matches a package pattern.

You can do these kinds of checks with ArchUnit I believe.

Originally posted by @ThomHurks in #2557 (comment)

Indeed it seems we can. I prototyped something like the following:

ArchRule noSunManagementInMethodSignatures = methods()
        .should().notHaveRawReturnType(resideInAPackage("com.sun.management.."))
        .andShould().notHaveRawParameterTypes(DescribedPredicate.anyElementThat(resideInAPackage("com.sun.management..")));

Thanks for the suggestions @ThomHurks.

[ThomHurks]

Glad to help!