Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrometheusRSocketClient's connection is timing out very often #86

Closed
klopfdreh opened this issue Aug 9, 2024 · 3 comments · Fixed by #87
Closed

PrometheusRSocketClient's connection is timing out very often #86

klopfdreh opened this issue Aug 9, 2024 · 3 comments · Fixed by #87

Comments

@klopfdreh
Copy link
Contributor

klopfdreh commented Aug 9, 2024

Currently PrometheusRSocketClient is timing out very often when trying to connect to the proxy-server.

It would be great to make the Duration of connectBlockingly(Duration timeout) configurable.

This would also affect prometheus-rsocket-spring properties, so that you can add a specific property to your application.yml

See: https://github.com/micrometer-metrics/prometheus-rsocket-proxy/blob/main/client/src/main/java/io/micrometer/prometheus/rsocket/PrometheusRSocketClient.java#L304

This might also relate to pushAndCloseBlockingly(Duration timeout);

@shakuzen shakuzen added the help wanted Extra attention is needed label Aug 9, 2024
@shakuzen
Copy link
Member

shakuzen commented Aug 9, 2024

Sounds reasonable to me. Would you be willing to submit a pull request for this?

@shakuzen shakuzen added the enhancement New feature or request label Aug 9, 2024
@shakuzen shakuzen added this to the 2.x milestone Aug 9, 2024
@klopfdreh
Copy link
Contributor Author

Yes I can provide a PR. 😀

@klopfdreh
Copy link
Contributor Author

Sounds reasonable to me. Would you be willing to submit a pull request for this?

PR is provided. 👍

@shakuzen shakuzen modified the milestones: 2.x, 2.0.0-RC1 Aug 15, 2024
@shakuzen shakuzen added module: client module: spring and removed help wanted Extra attention is needed labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants