Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Color for Enum Value - AL Language Syntax Highlights for Microsoft Dynamics 365 Business Central #7789

Open
pri-kise opened this issue Jul 5, 2024 · 4 comments
Assignees
Labels
accepted ado-syntax-highlighting Issues related to the new ADO syntax highlighting

Comments

@pri-kise
Copy link

pri-kise commented Jul 5, 2024

Please include the following with each issue:

1. Describe the bug
The enum value isn't highlighted correctly.

2. To Reproduce
Steps to reproduce the behavior:

  1. create an enum with with the values in a one line syntax.

image

Note: Because the developers need to copy and paste the code snippet, including a code snippet as a media file (i.e. .gif) is not sufficient.

3. Expected behavior
Everything that compiles should be highlighted correctly.

4. Actual behavior
No Highliting.

5. Versions:

  • AL Language Syntax Highlights for Microsoft Dynamics 365 Business Central: 12.7.944946 (Latest)

Internal work item: AB#540890

@thpeder
Copy link
Member

thpeder commented Jul 10, 2024

Hi @pri-kise,
I just tried to reproduce the issue, but this is what I see.
image

and you can also see that locked is not allowed, so I suspect the editor service crashed. Can you reproduce it?

@NKarolak
Copy link

@thpeder This is about the extension for DevOps, not for/in VS Code.

Locked is supported, but you need to replace the preceding semicolon with a comma - compare with pri-kise's code ;-)

@thpeder
Copy link
Member

thpeder commented Jul 10, 2024

Thanks for the help!
We will have a closer look at it.

@thpeder thpeder added ado-syntax-highlighting Issues related to the new ADO syntax highlighting accepted and removed input-needed syntax-highlighting labels Jul 10, 2024
@EmilDamsbo
Copy link
Member

Interestingly, this does work when your curly braces are not on the same line as the value(x; someName) declaration:
image

While we work on a fix to the issue, if this is bothering you, you could switch the enum value declaraton to one of the formats above which are working - dark mode aside, the highlighter works the same.

@EmilDamsbo EmilDamsbo self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted ado-syntax-highlighting Issues related to the new ADO syntax highlighting
Projects
None yet
Development

No branches or pull requests

4 participants