Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Connection Strings #1221

Closed
TimothyMothra opened this issue Sep 24, 2019 · 0 comments
Closed

SDK Connection Strings #1221

TimothyMothra opened this issue Sep 24, 2019 · 0 comments
Assignees
Milestone

Comments

@TimothyMothra
Copy link
Member

TimothyMothra commented Sep 24, 2019

Application Insights will start to support Connection Strings.
This will simplify the endpoint configuration necessary for some of our customers, specifically for customers that have a business need to connect to specific Azure Regions.
The Azure Portal will start displaying Connection Strings this week.
There will be an official blog post at a later date.

image

Ruleset

  1. check for explicit endpoint (location is ignored)
  2. check for endpoint suffix (location is optional)
  3. use classic endpoint (location is ignored)

Design

  • New property: TelemetryConfiguration.ConnectionString
  • New method: TelemetryConfiguration.SetConnectionString())
    Connection string needs to be parsed (via EndpointProvider) and validated.
    This method will set TelemetryConfiguration.InstrumentationKey.
    Resulting endpoints are set to TelemetryConfiguration.Endpoints (EndpointContainer).
    This method will also update TelemetryChannel.Endpoint

TODO

  • Need to integrate Javascript SDK with AspNetCore SDK. Waiting for new Javascript SDK to be released with connection string support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant