Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ILogger provider for apps targetting .NET Framework #1312

Closed
cijothomas opened this issue Mar 29, 2019 · 4 comments
Closed

Enable ILogger provider for apps targetting .NET Framework #1312

cijothomas opened this issue Mar 29, 2019 · 4 comments

Comments

@cijothomas
Copy link
Contributor

This (microsoft/ApplicationInsights-aspnetcore#853) enables ilogger by default for NETSTANDARD20. The project also targets NET46, and we need to ensure that apps targeting .net framework also should be able to use this change.

@cijothomas
Copy link
Contributor Author

apps targetting any .net framework dont get the new ilogger yet.

@cijothomas cijothomas transferred this issue from microsoft/ApplicationInsights-aspnetcore Nov 15, 2019
@SergeyKanzhelev
Copy link
Contributor

@cijothomas
Copy link
Contributor Author

SInce msft.extension.logging is only targetting netstandard2.0, we need to target net461 (or net472) in ilogger to consume it. This means aspnetcore project (which targets net45, net46) should additionally target net461 (or net472) - and enable auto ilogger integration for netstandard20 and net461(or net472).
This makes ilogger integration work well with .net core app targeting netet461 (or net472). We wont support older targets like net45 or net46.

@cijothomas
Copy link
Contributor Author

2.14.0-beta5 should have this.
Thanks @eddynaka and @rajkumar-rangaraj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants