Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log4netAppender depends on log4net 2.0.7 on targets that are not .netstandard1.3 #1675

Closed
jorisvergeer opened this issue Feb 12, 2020 · 1 comment
Milestone

Comments

@jorisvergeer
Copy link

jorisvergeer commented Feb 12, 2020

During some code cleanup I entoutered an issue with an assemblybinding

After some looking into the code of Log4Net appender I encountered this curious piece of code in the csproj file.

  <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
    <PackageReference Include="log4net" Version="2.0.8" />
  </ItemGroup>

  <ItemGroup Condition=" '$(TargetFramework)' != 'netstandard1.3' ">
    <PackageReference Include="log4net" Version="2.0.7" />
  </ItemGroup>

What is special about netstandard1.3 that only this target deserves 2.0.8?

Repro Steps

  1. Just add reference to Log4NetAppender

Actual Behavior

It depends on log4net 2.0.7

Expected Behavior

It depends on log4net 2.0.8

@TimothyMothra
Copy link
Member

We regularly find things that aren't supported in netstandard1.x
That's the intent here, but i would have expected this to be the other way around. Usually it's the older version that supports the older framework.
Maybe this was a typo.

Thanks for calling attention to this. I'll take a look at it today

@TimothyMothra TimothyMothra mentioned this issue Feb 12, 2020
4 tasks
@TimothyMothra TimothyMothra added this to the 2.14 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants