Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Make DependecyTypes from RemoteDependencyConstants public #2530

Open
OskarKlintrot opened this issue Jan 31, 2022 · 4 comments

Comments

@OskarKlintrot
Copy link
Contributor

Is your feature request related to a problem?
DependencyTelemetry.Type is a string but is set using constants from RemoteDependencyConstants. It would be nice to be able to use those constants instead of comparing to magic strings, for example "HTTP".

Describe the solution you'd like.
Some properties related to operation details in RemoteDependencyConstants got moved out to its own class in #2524. I suggest a similar solution here.

Describe alternatives you've considered.
Leave it as-is. Make the entire class RemoteDependencyConstants public. Use an enum.

Additional context.
This is suggested by @older in #1326.

@github-actions
Copy link

This issue is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label.

@github-actions github-actions bot added the stale label Nov 28, 2022
@OskarKlintrot
Copy link
Contributor Author

Not stale

@github-actions github-actions bot removed the stale label Nov 29, 2022
@OskarKlintrot
Copy link
Contributor Author

OskarKlintrot commented Aug 30, 2023

@cijothomas Does this seem like a good idea? I think I can open a PR if it does.

My suggestion: Move Microsoft.ApplicationInsights.DependencyCollector.Implementation.RemoteDependencyConstants up a notch to Microsoft.ApplicationInsights.DependencyCollector.RemoteDependencyConstants and make it public. What do you say?

@cijothomas
Copy link
Contributor

While the idea is good, I think its best to look into the OpenTelemetry based solutions (which are not quite as feature rich as this sdk, but getting there..), given that OTel is the long term direction for telemetry sdks.

(You may have noticed that this repo has stopped making any changes except security issues/updates to support newer .NET runtimes etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants