Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Update python bindings to follow the PEP 8 standard #1967

Open
icaven opened this issue Dec 15, 2023 · 0 comments · May be fixed by #1968
Open

Update python bindings to follow the PEP 8 standard #1967

icaven opened this issue Dec 15, 2023 · 0 comments · May be fixed by #1968

Comments

@icaven
Copy link

icaven commented Dec 15, 2023

There are a number of formatting issues in the python bindings that cause warnings in PEP 8 aware IDEs:

  • triple single quoted blocks for doc strings at the beginning of functions when they should be double quoted
  • missing colons after variable names in the descriptions in the doc string of functions
  • unused variables
  • variables initialized to None when they should be initialized to a value of the intended type
  • integer values used for initializing ctypes.c_bool when the python False should be used
  • duplicated imports
  • missing initialization of device index in Device (although it isn't used)
  • unnecessary parentheses around tuples in returns

None of these affect functionality or performance, but they it more difficult to see actual errors with these being flagged.

@icaven icaven linked a pull request Dec 15, 2023 that will close this issue
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant