Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lg template reference syntax #1308

Closed
boydc2014 opened this issue Oct 28, 2019 · 6 comments
Closed

Update lg template reference syntax #1308

boydc2014 opened this issue Oct 28, 2019 · 6 comments
Assignees
@yeze322 @zhixzhan
Labels
P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019

Comments

@boydc2014
Copy link
Contributor

LG is moving in the direction of deprecating the syntax of '[]', in favor of "@{}" for consistence.

And all the samples in SDK is using "@{}" already.

We should 3 places to present this new syntax,

  1. update samples
  2. the dialogFactory which do template creation
  3. the template extracting in dialogIndexer

to prompt this new syntax
@boydc2014 boydc2014 added Needs-triage A new issue that require triage R7 Release 7 - December 10th, 2019 labels Oct 28, 2019
@hibrenda hibrenda removed the Needs-triage A new issue that require triage label Oct 28, 2019
@vishwacsena
Copy link
Contributor

Do you need me to make a PR to update all the samples?

@yeze322 yeze322 self-assigned this Oct 30, 2019
@yeze322
Copy link
Contributor

yeze322 commented Oct 30, 2019 •
edited
Loading

Following this item in Composer area
Draft PR: #1351

@vishwacsena vishwacsena removed their assignment Oct 30, 2019
@cwhitten cwhitten added P0 Must Fix. Release-blocker P1 Painful if we don't fix, won't block releasing and removed P0 Must Fix. Release-blocker labels Nov 6, 2019
@yeze322 yeze322 added P0 Must Fix. Release-blocker and removed P1 Painful if we don't fix, won't block releasing labels Nov 26, 2019
@yeze322
Copy link
Contributor

yeze322 commented Nov 26, 2019

It's a blocker to Zhixiang, mark it as P0

This was referenced Nov 26, 2019
Closed
Merged
@cwhitten
Copy link
Member

cwhitten commented Dec 2, 2019

addressed in #1663

@cwhitten cwhitten closed this as completed Dec 2, 2019
@boydc2014 boydc2014 reopened this Dec 2, 2019
@boydc2014
Copy link
Contributor Author

reopen this to track the follow up work.

@cwhitten
Copy link
Member

cwhitten commented Dec 5, 2019

addressed in #1676

@cwhitten cwhitten closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeze322 yeze322

@zhixzhan zhixzhan

Labels
P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cwhitten @boydc2014 @yeze322 @vishwacsena @hibrenda @zhixzhan