Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn upgrade failed on "botbuilder-expression-parser@^4.5.11" #1590

Closed
2 of 7 tasks
WTobor opened this issue Nov 15, 2019 · 6 comments
Closed
2 of 7 tasks

Yarn upgrade failed on "botbuilder-expression-parser@^4.5.11" #1590

WTobor opened this issue Nov 15, 2019 · 6 comments
Assignees
@cwhitten
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. P1 Painful if we don't fix, won't block releasing

Comments

@WTobor
Copy link

WTobor commented Nov 15, 2019 •
edited
Loading

Version

branch master, commit d0ed216f

Browser

What browser are you using?

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

What operating system are you using?

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Run yarn upgrade (according to error message during build)
    image

Expected behavior

Upgrade works

Screenshots

image
@WTobor WTobor added the Needs-triage A new issue that require triage label Nov 15, 2019
@WTobor
Copy link
Author

WTobor commented Nov 15, 2019

So I cannot build application from the latest commit. When I move back to commit 326026e, build works.

@hibrenda
Copy link
Contributor

@WTobor we don't support yarn upgrade. Please follow the installation instruction : yarn install -> yarn build -> yarn start

@WTobor
Copy link
Author

WTobor commented Nov 15, 2019

Thanks for the response. Maybe consider adding this information in console output (after failed build)? ;)

@cwhitten cwhitten added Needs investigation and removed Needs-triage A new issue that require triage labels Nov 15, 2019
@cwhitten
Copy link
Member

We will attempt to update the text that comes out of the tooling to not confuse users - thanks for the feedback!

@hibrenda hibrenda added P1 Painful if we don't fix, won't block releasing and removed Needs investigation labels Nov 19, 2019
@Stevenic Stevenic added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Nov 22, 2019
@cwhitten cwhitten mentioned this issue Nov 24, 2019
Merged
@Kaiqb
Copy link
Contributor

Kaiqb commented Nov 25, 2019

Removing doc label as this doesn't seem to be a doc issue.

@hibrenda
Copy link
Contributor

hibrenda commented Dec 4, 2019

close this issue as it is already addressed in #1645

@hibrenda hibrenda closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwhitten cwhitten

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Stevenic @cwhitten @WTobor @Kaiqb @hibrenda