Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property editor font size adjustments #1693

Closed
sangwoohaan opened this issue Dec 3, 2019 · 1 comment
Closed

Property editor font size adjustments #1693

sangwoohaan opened this issue Dec 3, 2019 · 1 comment
Assignees
@tdurnford
Labels
R8 Release 8 - March 16th, 2020

Comments

@sangwoohaan
Copy link
Contributor

sangwoohaan commented Dec 3, 2019 •
edited
Loading

There are a few gaps between the design and the build that can provide an immediate improvement by addressing them

Screen Shot 2019-12-03 at 2 00 41 PM

  1. The sub-label ("Prompt for text" in the screenshot) font weight should be 400 (currently 600)
  2. Prompt tab("Bot asks", "User input", "Other") font size is 16px (currently 18px)
  3. Input field title("Property to fill") font size is 12px (currently 14px)
  4. There's a 10px gap between the prompt tabs and the stroke above them(currently 0px)
@sangwoohaan sangwoohaan added the Needs-triage A new issue that require triage label Dec 3, 2019
@cwhitten cwhitten added R8 Release 8 - March 16th, 2020 and removed Needs-triage A new issue that require triage labels Dec 5, 2019
@DesignPolice
Copy link

I added a quick link and updated spec for this... just keeping the spacing consistent. Spaces are in increments of 4 (4,8,12,16...) this makes it easier to have less options and no strange odd numbers.

https://www.figma.com/file/Ux0vucOvaLL2xH22WpFgV65X/MarcB_Composer-UI?node-id=4095%3A28034

Screen Shot 2019-12-09 at 9 42 24 AM

@DesignPolice DesignPolice removed their assignment Jan 6, 2020
@tdurnford tdurnford mentioned this issue Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdurnford tdurnford

Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cwhitten @a-b-r-o-w-n @tdurnford @hibrenda @DesignPolice @sangwoohaan