Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lg content does not show in **Send a response** action node #1700

Closed
zxyanliu opened this issue Dec 4, 2019 · 4 comments
Closed

lg content does not show in **Send a response** action node #1700

zxyanliu opened this issue Dec 4, 2019 · 4 comments
Assignees
@yeze322 @zhixzhan
Labels
P0 Must Fix. Release-blocker Type: Bug Something isn't working

Comments

@zxyanliu
Copy link
Contributor

zxyanliu commented Dec 4, 2019 •
edited
Loading

Describe the bug

I authored lg inline, but the content does not show in Send a response action node.

Screenshots

image
@zxyanliu zxyanliu added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Dec 4, 2019
@hibrenda
Copy link
Contributor

hibrenda commented Dec 4, 2019

similar to this #1212

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Dec 5, 2019
@yeze322
Copy link
Contributor

yeze322 commented Dec 5, 2019 •
edited
Loading

broke by changes in #1676
image
this will trigger a 'postMessage' error
image
@zhixzhan
LgParser cannot be executed in ShellApi

@hibrenda hibrenda added the P0 Must Fix. Release-blocker label Dec 5, 2019
@zhixzhan zhixzhan mentioned this issue Dec 5, 2019
Merged
5 tasks
@zhixzhan
Copy link
Contributor

zhixzhan commented Dec 5, 2019 •
edited
Loading

broke by changes in #1676
image
this will trigger a 'postMessage' error
image
@zhixzhan
LgParser cannot be executed in ShellApi

@yeze322 shell used Window.postMessage API will clone json message body, and body need to be a plain object. raw parse result contains prototype methods can't be cloned. it need to be filtered
fixed in #1707

@zhixzhan
Copy link
Contributor

zhixzhan commented Dec 9, 2019

Addressed in #1707

@zhixzhan zhixzhan closed this as completed Dec 9, 2019
@yeze322 yeze322 mentioned this issue Dec 10, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeze322 yeze322

@zhixzhan zhixzhan

Labels
P0 Must Fix. Release-blocker Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cwhitten @yeze322 @zxyanliu @hibrenda @zhixzhan