From a05ad1c1a954c4d0634bb06603f3131bd9d3eb60 Mon Sep 17 00:00:00 2001 From: William Wong Date: Tue, 23 Jul 2019 16:06:42 +0900 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com> --- CHANGELOG.md | 2 +- __tests__/setup/pageObjects/sendFile.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1277625121..76e48b62fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,7 +59,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Added - Added bubble nub and style options, by [@compulim](https://github.com/compulim), in PR [#2137](https://github.com/microsoft/BotFramework-WebChat/pull/2137) -- Make thumbnails for uploading GIF/JPEG/PNG and store it in `channelData.attachmentThumbnails`, by [@compulim](https://github.com/compulim), in PR [#2206](https://github.com/microsoft/BotFramework-WebChat/pull/2206), requires modern browsers with following features: +- Make thumbnails when uploading GIF/JPEG/PNG and store it in `channelData.attachmentThumbnails`, by [@compulim](https://github.com/compulim), in PR [#2206](https://github.com/microsoft/BotFramework-WebChat/pull/2206), requires modern browsers with following features: - [Web Workers API](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API) - [`createImageBitmap`](https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/createImageBitmap) - [`MessageChannel`](https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel)/[`MessagePort`](https://developer.mozilla.org/en-US/docs/Web/API/MessagePort) diff --git a/__tests__/setup/pageObjects/sendFile.js b/__tests__/setup/pageObjects/sendFile.js index a2f2e375b0..7ef1418f41 100644 --- a/__tests__/setup/pageObjects/sendFile.js +++ b/__tests__/setup/pageObjects/sendFile.js @@ -17,7 +17,7 @@ export default async function sendFile(driver, filename, { waitForSend = true } const uploadButton = await getUploadButton(driver); const isUnderDocker = !!(await driver.getCapabilities()).get('webdriver.remote.sessionid'); - // The send file function is asynchronous, it don't send immediate until thumbnails are generated. + // The send file function is asynchronous, it doesn't send immediately until thumbnails are generated. // We will save the numActivities, anticipate for numActivities + 1, then wait until everything is sent const numActivities = (await getActivityElements(driver)).length;