Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Portal: Remove "Enable Preview" from channel settings #1086

Closed
3 tasks
compulim opened this issue Aug 15, 2018 · 5 comments
Closed
3 tasks

Azure Portal: Remove "Enable Preview" from channel settings #1086

compulim opened this issue Aug 15, 2018 · 5 comments
Assignees
Labels
front-burner p0 Must Fix. Release-blocker size-xl 9-14 days
Milestone

Comments

@compulim
Copy link
Contributor

compulim commented Aug 15, 2018

  • Remove "Enable preview" check box
  • Add a new "Use deprecated version" check box
  • By default, will load the latest version (v4)
@compulim compulim self-assigned this Aug 15, 2018
@compulim compulim added this to the v4 milestone Aug 15, 2018
@compulim compulim removed the v4 label Aug 15, 2018
@compulim compulim added the 4.2 label Oct 30, 2018
@compulim compulim changed the title Web Chat: Remove "Enable Preview" from channel settings Azure: Remove "Enable Preview" from channel settings Oct 30, 2018
@compulim compulim changed the title Azure: Remove "Enable Preview" from channel settings Azure Portal: Remove "Enable Preview" from channel settings Oct 30, 2018
@compulim compulim modified the milestones: v4, v4.2 Oct 30, 2018
@sgellock sgellock added 4.3 and removed 4.2 labels Nov 27, 2018
@corinagum corinagum added Approved front-burner p0 Must Fix. Release-blocker labels Nov 28, 2018
@compulim compulim modified the milestones: v4.2, v4.3 Nov 28, 2018
@compulim compulim added size-l 4-8 days size-xl 9-14 days and removed size-l 4-8 days labels Dec 8, 2018
@compulim compulim modified the milestone: v4.3 Dec 18, 2018
@compulim compulim removed their assignment Dec 18, 2018
@compulim compulim added the community-help-wanted This is a good issue for a contributor to take on and submit a solution label Dec 18, 2018
@compulim
Copy link
Contributor Author

@seaen

  • Can you rephrase "use deprecated version"?
  • Can you write us a story on this one? E.g. Adaptive Cards compatibility

@compulim
Copy link
Contributor Author

compulim commented Apr 1, 2019

This is my main feature for 4.4. There are lots of discussions between Web Chat and the service team about this issue. The design has been flushed out and ready to implement.

@corinagum
Copy link
Contributor

Adding to discussion from #1885 by @mahomedalid

The Azure Bot Registration section displays an iframe embed code as a suggested way to solve an integrated webchat on your site, but seems ConversationUpdate is not being triggered because it doesn't inject the user id by default.
I see there is a similar issue (#752) but the fact that the iframe is the "recommended way" (at least from the azure portal perspective) make me think that we can improve the experience, maybe suggesting a snippet of code using webchat.

@compulim, here are some additional questions I want to add on.

  1. Can you give a general summary of how the service side's Web Chat will be changing? How will users, for example, pass in user id to trigger ConversationUpdate?
  2. Will iframe still be used? What about secrets vs tokens, and versioning?
  3. Do you have other details about pending changes that customers would be interested in?

I think once the major update is made, we should also discuss how and where we will keep documentation related to ABS side of Web Chat. Right now we don't have much documentation about ABS Web Chat because it is v3, especially on this repo, but we should work to improve that.

@compulim
Copy link
Contributor Author

  1. conversationUpdate will still the same as of today
    • There will be no way to send custom welcome message, anyone interested, please open a bug to discuss
    • (New) Like today, developers can specify userid, if it is conflict with JWT token, we will use the one from JWT token
    • Like today, if userid is not specified, we will randomly create one and store it in cookie of webchat.botframework.com
  2. Yes, we are still iframe. Our target scenario is still the same, "static web site". After this work is done, we will talk to channel team about using HTTP referrer to secure secret
    • Versioning, we support "latest", "fixed major version", and "fixed minor version". We do not support "fixed patch version"
      • It is very likely we will support fixed version for 2 years after they go production
      • After 2 years, we will bump automatically
      • Developers can keep using the "old v3" versions, by specifying ibiza as the version number
    • We will roll out new versions gradually (A/B on percentage)
  3. Few interesting things
    • This rework will enable us to provide more functionalities easily, please open bugs for feature suggestions
      • postMessage API, e.g. controlling greedy focus
      • Setting styleOptions via JSON file
      • Minimizable UI with proactive messaging support
    • We will enable OAuth, but magic code is always required due to security reason
    • It is very likely we will put the source code of the embed page on GitHub
    • It is very likely for a new REST API, used by the embed page, to obtain bot configurations, including bot name, bot icon URL, etc
    • Bot avatar will be shown in v4 automatically if bot icon is uploaded in Azure Portal
    • Using v4, we will not show a title bar (same as CDN/NPM), developers are advised to wrap the <iframe> with a <div> to show the title, this is because the customization of title varies a lot
    • Greedy focus is removed in v4, but still be provided in v3

@compulim
Copy link
Contributor Author

This is done. We will switching it on gradually over the next few weeks.

@corinagum corinagum unpinned this issue May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-burner p0 Must Fix. Release-blocker size-xl 9-14 days
Projects
None yet
Development

No branches or pull requests

5 participants