Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests for post-4.5 release #2158

Closed
12 tasks done
corinagum opened this issue Jul 8, 2019 · 1 comment · Fixed by #2293 or #2299
Closed
12 tasks done

Write more tests for post-4.5 release #2158

corinagum opened this issue Jul 8, 2019 · 1 comment · Fixed by #2293 or #2299
Assignees
Labels
front-burner p1 Painful if we don't fix, won't block releasing

Comments

@corinagum
Copy link
Contributor

corinagum commented Jul 8, 2019

Feature Request

Is your feature request related to a problem? Please describe.
No

Describe the suggestion or request in detail
The following issues (mostly speech-related) should have more tests written:

Also, the mockWebSpeech.js file needs more coverage in these areas:

Speech tests around consecutive activities with different inputHint

Note that 1st and 2nd activity could sometimes have a slight delay between them, ~1 second.

1st activity 2nd activity Should turn on microphone if via keyboard Should turn on microphone if via microphone
Accepting input Accepting input No No
Accepting input Expecting input No Yes
Accepting input Ignoring input No No
Expecting input Accepting input No Yes
Expecting input Expecting input No Yes
Expecting input Ignoring input No No (explicitly turn it off)
Ignoring input Accepting input No No
Ignoring input Expecting input No Yes
Ignoring input Ignoring input No No

Reliability issues

  • suggested-actions command should show suggested actions with images
    • After emptycard was sent, we didn't wait until suggested actions show up
    • Today, we use minNumActivitiesShown to test, but this cannot be used to test empty card or suggested actions
    • Use suggestedActionsShowed condition to wait until suggested actions show up before taking the snapshot

Describe alternatives you have considered
N/A

[Enhancement]

@compulim
Copy link
Contributor

Reopening, we still have the input hint need to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
2 participants