Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: Build not working after importing microsoft-cognitiveservices-speech-sdk #2521

Closed
compulim opened this issue Oct 31, 2019 · 0 comments · Fixed by #2522
Closed

IE11: Build not working after importing microsoft-cognitiveservices-speech-sdk #2521

compulim opened this issue Oct 31, 2019 · 0 comments · Fixed by #2522
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@compulim
Copy link
Contributor

Screenshots

image

Version

master

Describe the bug

After importing from microsoft-cognitiveservices-speech-sdk from commit 8d06a54, we are bundling non-ES5 code in webchat-es5.js.

To Reproduce

Steps to reproduce the behavior:

  1. Host webchat-es5.js and browse it under IE11

Expected behavior

Expect Web Chat to load.

Instead, Web Chat failed with "unexpected identifier" error due to bundling issues.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Oct 31, 2019
@compulim compulim mentioned this issue Oct 31, 2019
Merged
1 task
@compulim compulim mentioned this issue Oct 31, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limiting scope of imports for microsoft-cognitiveservices-speech-sdk compulim/BotFramework-WebChat
1 participant
@compulim