Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimizable sample should not reconnect #2609

Closed
Karim-khadro opened this issue Nov 18, 2019 · 6 comments · Fixed by #2758
Closed

Minimizable sample should not reconnect #2609

Karim-khadro opened this issue Nov 18, 2019 · 6 comments · Fixed by #2758
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@Karim-khadro
Copy link

Karim-khadro commented Nov 18, 2019

Direct line reconnects to the bot framework after minimiz and maximiz the bot window in the browser

  • The impact :
    The user will receive a welcome message after every time he changes the window size

  • Test environment:
    1- Download the minimizable web chat example
    2- Then update web chat from 4.5.1 to 4.6.0
    3- After reciving the welcome message from the bot click on minimz button then click on maximiz button

  • Please find below the screenshot attached for reference.
    First connection
    2019-11-18_15h40_47

After minimiz and maximiz the window

2019-11-18_15h40_02

Web chat version 4.6.0

@Karim-khadro Karim-khadro added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. labels Nov 18, 2019
@Karim-khadro Karim-khadro changed the title Minimize button Web Chat 4.6.0 Minimiz button Web Chat 4.6.0 Nov 18, 2019
@cwhitten
Copy link
Member

@corinagum can you please take a look at this?

@tdurnford
Copy link
Contributor

The sample dispatches a backcahnnel welcome event on each DIRECT_LINE/CONNECT_FULFILLED action which is triggered each time the chat window is expanded. We should add a state variable to track if the backchannel welcome event has already been triggered before we send it to the bot.

@corinagum
Copy link
Contributor

I'll try to patch this up tonight.

@corinagum corinagum added customer-replied-to Required for internal reporting. Do not delete. and removed Pending labels Nov 19, 2019
@corinagum
Copy link
Contributor

@compulim told me he's going to be making changes to this sample over the next week for ic3 work, so I will reassign this to him.

@corinagum corinagum assigned compulim and unassigned corinagum Nov 19, 2019
@compulim
Copy link
Contributor

Will work on this later today.

@compulim compulim changed the title Minimiz button Web Chat 4.6.0 Minimize button Web Chat 4.6.0 Dec 16, 2019
@compulim
Copy link
Contributor

@karimkhadro96 we are fixing it in #2758.

This is not an ideal fix. I opened a discussion issue #2750 and resolving it would unblock the ideal fix.

As #2750 described, we can't mount/unmount Web Chat without connect/disconnect Direct Line. So currently, we can only hide Web Chat but not releasing the memory.

There are few hacks, but I would prefer to resolve the bug in an ideal way.

@compulim compulim changed the title Minimize button Web Chat 4.6.0 Minimizable sample should not reconnect Dec 18, 2019
@compulim compulim mentioned this issue Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants