Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUserMedia Support on network address #2668

Closed
srinaath opened this issue Dec 5, 2019 · 5 comments · Fixed by #3079
Closed

getUserMedia Support on network address #2668

srinaath opened this issue Dec 5, 2019 · 5 comments · Fixed by #3079
Assignees
Labels
area-speech bug Indicates an unexpected problem or an unintended behavior. p1 Painful if we don't fix, won't block releasing
Milestone

Comments

@srinaath
Copy link

srinaath commented Dec 5, 2019

Screenshots

UserMedia

network address

Version

Master Branch Latest Bits

Describe the bug

Directline Speech icon click works fine on localhost whereas on the network URL served it breaks

Steps to reproduce

  1. Go to https://github.com/compulim/webchat-bugbash-dlspeech#create-azure-speech-resource
  2. Follow steps in this repo
  3. Once you serve it as a webapp we get a localhost URL and a network URL.
  4. The Speech functionality fails with the error attached in the screenshot when u open the network URL it is served on

Expected behavior

Clicking the speech icon does not generate the console error and converts the speech to text in the input box

[Bug]

@corinagum corinagum added area-direct-line-speech bug Indicates an unexpected problem or an unintended behavior. Pending labels Dec 5, 2019
@compulim
Copy link
Contributor

compulim commented Dec 5, 2019

Is it because microphone access to the browser is blocked?

@corinagum
Copy link
Contributor

corinagum commented Dec 5, 2019

I am able to repro, and no, my browser had microphone permissions.

@corinagum corinagum removed the Pending label Dec 5, 2019
@compulim
Copy link
Contributor

compulim commented Dec 5, 2019

Is it because http vs https?

Browser don't offer media recording capability when web page is served over HTTP instead of HTTPS.

On the other hand, we should better surface the error. In this case, we should disable microphone button (turn it into envelope).

@gabog gabog added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Dec 5, 2019
@corinagum
Copy link
Contributor

@gabog, @srinaath is a team member xD Removing tags

@corinagum corinagum removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Dec 5, 2019
@corinagum corinagum assigned compulim and unassigned corinagum Dec 5, 2019
@cwhitten cwhitten added R8 p1 Painful if we don't fix, won't block releasing labels Jan 9, 2020
@cwhitten
Copy link
Member

cwhitten commented Jan 9, 2020

note to fixer: if for some reason getUserMedia fails we should not show the microphone button in the control

@corinagum corinagum added this to the R8 milestone Jan 15, 2020
@cwhitten cwhitten added R9 and removed R8 labels Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-speech bug Indicates an unexpected problem or an unintended behavior. p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants