Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n: Cannot load sr-Cyrl and sr-Latn #2977

Closed
compulim opened this issue Mar 5, 2020 · 0 comments · Fixed by #2978
Closed

I18n: Cannot load sr-Cyrl and sr-Latn #2977

compulim opened this issue Mar 5, 2020 · 0 comments · Fixed by #2978
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Mar 5, 2020 •
edited
Loading

Version

master of now.

Describe the bug

In packages/component/src/Utils/normalizeLanguage.js:

- } else if (language.startsWith('sr-Cyrl')) {
+ } else if (language.startsWith('sr-cyrl')) {
    return 'sr-Cyrl';
- } else if (language.startsWith('sr-Latn')) {
+ } else if (language.startsWith('sr-latn')) {
    return 'sr-Latn';

Steps to reproduce

  1. Set locale prop to sr-Cyrl

Expected behavior

It should display Serbian (Cyrillic). Instead, it display English (US).

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Mar 5, 2020
@compulim compulim mentioned this issue Mar 5, 2020
Merged
1 task
@compulim compulim mentioned this issue Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sr-Cyrl and sr-Latn compulim/BotFramework-WebChat
1 participant
@compulim