Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: The highlighted links below does not indicate whether they are internal or external links and whether they open in new window or not #3087

Closed
ericmaino opened this issue Apr 7, 2020 · 7 comments · Fixed by #3817 or #3827
Assignees
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker
Milestone

Comments

@ericmaino
Copy link

image

Actual
In LHS screenshot.

  • The first link is internal link and opens in a new window. There is no title attribute = “opens in a new window”. Also “opens in a new window” icon is not present.
  • The second and third links are external links and opens in a new window. There is no title attribute = “opens in a new window, external”.

Expected
Add title attribute as mentioned above and also use icons to represent “external links” and “links opening in new window”

WCAG Violation
Predictable
https://www.w3.org/TR/WCAG20-TECHS/G201.html

@ericmaino ericmaino added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Apr 7, 2020
@corinagum
Copy link
Contributor

These are accessibility issues of v3 of Web Chat, which has been deprecated and we no longer support unless there are security risks. For accessible Web Chat, please migrate to v4.

@ericmaino
Copy link
Author

This issue is still present in v4. I'll investigate and propose submit a PR with a fix

@ericmaino ericmaino reopened this Apr 9, 2020
@ericmaino ericmaino self-assigned this Apr 9, 2020
@compulim
Copy link
Contributor

In Web Chat v4, all links will be opened externally in a new tab. Please let us know if this is not true.

@compulim compulim added the customer-replied-to Required for internal reporting. Do not delete. label Apr 10, 2020
@JorgeCupiV
Copy link

While they open externally, there's still a need for the title property to show that the link is being open externally.

@corinagum corinagum added needs-team-attention needs-scheduling backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. needs-team-attention labels Sep 23, 2020
@compulim compulim added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Oct 5, 2020
@corinagum corinagum added this to the R12 milestone Dec 21, 2020
@corinagum corinagum removed backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner labels Jan 13, 2021
@Quirinevwm
Copy link

Quirinevwm commented Jan 25, 2021

UX recommendation:
For communication purposes definitely include the transcript "opens link in a new window", Whenever there is a deep link include this transcript for accessibility, since both types (internal, external) will have this behavior.

Regarding the icon ask:

  • Stick to deep link only, since all links will be opened in a new window in V4, there is no difference between "internal" and "external" links regarding behavior. Hence, why I would recommend to not place any icon there. The content will look messy, when after every link (both internal, external) we position a hovering icon that represents opening. Also when multiple "categorized" links will be places after , link (icon), link (icon), link (icon).

  • If you do really need to position an icon after every link, go for consistency since both types of links share the same behavior, go for the The Fluent System library icon represents "open":
    image
    https://iconcloud.design/search/filter/Fluent%20System%20Library/Fluent%20Regular/open/8406032d3-3821b375b

@corinagum corinagum removed the needs-design-input UX/UI design item label Jan 25, 2021
@corinagum corinagum added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Mar 10, 2021
@corinagum corinagum assigned corinagum and unassigned compulim and Quirinevwm Mar 10, 2021
@corinagum corinagum removed needs-scheduling needs-team-attention backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Mar 10, 2021
@compulim
Copy link
Contributor

Modify renderMarkdown.js, some code in this snippets:

image

It is easy to add aria-label (or other ARIA attributes), unsure if it is easy to add an icon in the Markdown tree.

@corinagum
Copy link
Contributor

corinagum commented Mar 10, 2021

note to self: timebox 1-2 days to see how to add HTML elements for aria-label and icon
take notes on behavior functions in renderMarkdown.js & documentation - notes to customer on how to match renderMarkdown.js behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker
Projects
None yet
7 participants