Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 windows opened by Action.OpenUrl from an Adaptive Card is not resizable or scrollable #3483

Closed
gudatcomputers opened this issue Sep 16, 2020 · 7 comments · Fixed by #3607
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker size-s 1 days or less
Milestone

Comments

@gudatcomputers
Copy link

Screenshots

Version

4.9.1+ - downloaded from CDN, hosted locally

We are using webchat-es5.js with HealthBot.

When using IE11 (11.1685.16299.0), when choosing Action.OpenUrl from an Adaptive Card the opened window is fixed size with no scrollbars.

Not sure if the fix [#3223] is the cause, but this issue occurs first in 4.9.1

Steps to reproduce

  1. Open any HealthBot scenario with an Action.OpenUrl Adaptive Card
  2. Click the link
  3. See the window opened with a fixed size and no scrollbars

Expected behavior

window that opens as a result of Action.OpenUrl is scrollable and resizable

@gudatcomputers gudatcomputers added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Sep 16, 2020
@tsuwandy
Copy link

@corinagum, could you take a look?

@corinagum
Copy link
Contributor

@gudatcomputers please provide the Adaptive Card you are using that reproduces this scenario.
What question flow on the Health Bot needs to be followed in order to produce the Adaptive Card?

@corinagum corinagum added the customer-replied-to Required for internal reporting. Do not delete. label Sep 16, 2020
@gudatcomputers
Copy link
Author

gudatcomputers commented Sep 16, 2020

@corinagum Here's the card content.. basic card. As far as having a public version of it, I had to roll it back to 4.9.0 to address the issue. Is that crucial?

{
	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
	"type": "AdaptiveCard",
	"version": "1.0",
	"body": [],
        "actions": [
        {
            "type": "Action.OpenUrl",
            "title": customLocalizedStrings['testing_answer_test_type_home_test'],
            "url": scenario.signupFormBaseUrl +"?testType=in-home"&conversationId=" + scenario.scenarioArgs.conversationId 
        },
        {
            "type": "Action.OpenUrl",
            "title": customLocalizedStrings['testing_answer_test_type_test_site'],
            "url": scenario.testLocatorUrl + "?conversationId=" + scenario.scenarioArgs.conversationId
        },       
	]
}       

@corinagum
Copy link
Contributor

@gudatcomputers First let me try and get a repro on our Web Chat bot first, and I'll get back to you. :)

@corinagum
Copy link
Contributor

corinagum commented Sep 16, 2020

I'm able to reproduce this outside of Web Chat on IE11, using noopener with the following:
window.open('https://github.com/Microsoft/BotFramework-WebChat', '_blank', 'noopener')

Ideas/options:

  1. Remove rel if browser is IE11 - not recommended, since this is a security change
  2. Remove target if browser is IE11?
  3. No action, means continued broken behavior in IE11 only.

Currently, I am investigating other options to ensure we choose the securest option. I will report back.

@gudatcomputers thanks, for now I don't need anything from the Health Bot. :)

@gudatcomputers
Copy link
Author

Thanks @corinagum we're, obviously, functional on 4.9.0 for now. Thanks for looking into alternatives.

@corinagum corinagum added this to the Needs-scheduling milestone Sep 18, 2020
@corinagum
Copy link
Contributor

After doing some research, I think the best solution is to isolate a separate behavior for IE11, which would be to assign noreferrer, but not noopener, then manually set window.open to null, which resolves original issue when tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker size-s 1 days or less
Projects
None yet
4 participants