Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEYBOARD]: Links in the chat log must be keyboard focusable #3933

Closed
ianpsant opened this issue Jun 9, 2021 · 5 comments · Fixed by #4108
Closed

[KEYBOARD]: Links in the chat log must be keyboard focusable #3933

ianpsant opened this issue Jun 9, 2021 · 5 comments · Fixed by #4108
Assignees
Labels
area-accessibility backlog Out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report external-dova

Comments

@ianpsant
Copy link

ianpsant commented Jun 9, 2021

Please view our Technical Support Guide before filing a new issue.

Screenshots

links-not-focusable.mov

Version

<meta name="botframework-directlinespeech:version" content="4.12.0">
<meta name="botframework-webchat:bundle:variant" content="full-es5">
<meta name="botframework-webchat:bundle:version" content="4.12.0">
<meta name="botframework-webchat:core:version" content="4.12.0">
<meta name="botframework-webchat:ui:version" content="4.12.0">

Describe the bug

The links added to the VA chatbot's responses are not reachable by keyboard when I am navigating through the page with the TAB key. Quicktime movie attached below.

Steps to reproduce

  1. Links can be confirmed to receive keyboard focus when navigating with the TAB key
  2. This can be verified by typing document.activeElement into the Chrome DevTools console

Expected behavior

Additional context

We cannot make links in the chat log tabbable. We tried adding tab indexes to the links, but this does not solve this issue. Corresponds to this VA GitHub issue: department-of-veterans-affairs/va.gov-team#25156

[Bug]

@ianpsant ianpsant added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Jun 9, 2021
@Kaiqb Kaiqb added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Jun 9, 2021
@mrivera-ms mrivera-ms added the ExemptFromDailyDRIReport exempt from daily DRI report label Jun 14, 2021
@compulim compulim self-assigned this Sep 16, 2021
@compulim
Copy link
Contributor

compulim commented Oct 6, 2021

The transcript is modelled as a composite widget. End-user would need to use arrow keys to select activity, then press ENTER key to put focus in the activity. While they are navigating using arrow keys, screen reader should narrate "click to interact" for activities with links (or buttons, <input> and other interactive elements).

It seems the discoverability about keyboard commands are not clear or explicit for the end-user to understand. We have discussed and should add a help screen for keyboard users.

@compulim
Copy link
Contributor

I am still waiting for our designer to complete the design of the new keyboard commands modal.

@jgacek
Copy link

jgacek commented Nov 30, 2021

After discussion with Aaron to resolve this ticket we would require that once focus is on an activity that you would be able to interact with all the links within it and for you to be able to back out of the activity.

  1. User uses arrow to navigate activities
  2. User hits enter to enter activity
  3. User should be able to navigate between all the link/buttons within activity
  4. User should be able to leave the activity

@compulim
Copy link
Contributor

compulim commented Nov 30, 2021

Agree and it should be doable today.

For step 3, after focusing in the activity, the user press TAB orSHIFT + TAB to jump between links/buttons.

For step 4, the user will leave the activity and go back to step 1 if they do one of the following:

  • Press ESCAPE
  • Press TAB on the last links/buttons in the activity
  • Press SHIFT + TAB on the first links/buttons in the activity

@LucianaAlexanderMorais
Copy link

This was a rough experience. We definitely need to work on improving this if we can. Right now I am drafting directions to place on the main page when we launch the bot:

"Please note, we are currently working on improving accessibility on this virtual agent.
We apologize for any inconvenience.

To start using the virtual agent with a screen reader, you can:

  1. Tab to select the virtual agent window
  2. Tab to select the "Accept" button and press Enter
  3. Use arrow keys to listen to chatbot messages
  4. Tab to select the "Type your message" section
  5. Ask your question and press Enter
  6. Use Shift+Tab to move back to messages
  7. Use arrow keys to focus on a specific message.
  8. Press Enter to focus on a link
  9. Press Enter again to open a link. Link will open on another page.
  10. Use Shift+Tab to exit the chatbot window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility backlog Out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report external-dova
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants