Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen Reader - Bot Framework Web Chat- Help]: Headings are not defined programmatically on cards showing for Help keyword #4015

Closed
v-duku opened this issue Aug 11, 2021 · 8 comments · Fixed by #4074 or #4106
Assignees
Labels
Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Milestone

Comments

@v-duku
Copy link

v-duku commented Aug 11, 2021

User Experience:

If headings are not defined programmatically on cards showing for Help keyword, then screen reader user will be disoriented and will not be able to navigate in heading mode. The user will also be facing issues while accessing and navigating on the page.

Note: Login Credentials must not be provided within the bug.

Test Environment:

OS Version: 21H1
OS Build: 19043.1110
Browser: Microsoft Edge Version 94.0.972.2 (Official build) dev (64-bit)
Screen Reader: Narrator

Repro steps:

  1. Open URL Provided by product owner.
  2. Web chat bundle will open.
  3. Navigate on the web chat bot and select microphone icon.
  4. Speak "help" keyword in Type your message box, then select send button.
  5. Cards related to the keyword will appear, navigate on the cards.
  6. Verify the issue.

Actual Result

Headings are not defined programmatically on cards showing for Help keyword. 'Accessibility' heading is not defined in heading tags.

Expected Result

Headings should be defined programmatically on cards showing for Help keyword. 'Accessibility' heading should be defined in heading tags.

Note: This issue exists with similar controls throughout the application.

MAS Reference

WCAG 2.4.6 – Headings and Labels

Reference Links

Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.

@v-duku v-duku added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Aug 11, 2021
@v-duku v-duku changed the title test [Screen Reader - Bot Framework Web Chat- Help]: Headings are not defined programmatically on cards showing for Help keyword Aug 11, 2021
@v-duku
Copy link
Author

v-duku commented Aug 11, 2021

#A11yMAS;#A11ySev2;#HCL;#WCAG2.4.6;#Accessibility;#Win10-Edge(Chromium);#BotFrameworkWebChat-Aug21;

@compulim
Copy link
Contributor

@v-duku could you try this out when using Adaptive Cards independently? You can use the Adaptive Card designer in preview mode to check its accessibility.

FYI, our help command is actually sending multiple Adaptive Cards.

@compulim compulim added the customer-replied-to Required for internal reporting. Do not delete. label Aug 11, 2021
@compulim compulim added this to the R15 milestone Aug 23, 2021
@compulim
Copy link
Contributor

@v-duku are you saying the "XML message" text in the screenshot below should be defined as <h1> (or <h2>...)?

image

In Adaptive Cards, there is no way for us to define whether a TextBlock is a header or not. You can see the schema here, https://adaptivecards.io/explorer/TextBlock.html.

Seems this is a bug/ask on Adaptive Cards side to add indication of header in TextBlock.

@compulim
Copy link
Contributor

Adaptive Cards schema 1.5 will support style: 'heading' in TextBlock element, which will resolve this issue.

microsoft/AdaptiveCards#5698

@compulim compulim self-assigned this Sep 13, 2021
@compulim compulim added the Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 label Sep 27, 2021
@compulim
Copy link
Contributor

compulim commented Sep 28, 2021

Status: Waiting for external

Talked to AC team. They are expecting to ship AC library 2.10.0 with support of AC schema 1.5 in a couple of weeks ahead.

They have 2.10.0.beta-2 up and asked us to try it out and see if the behavior is desirable or not. Will have an update soon.

@compulim
Copy link
Contributor

compulim commented Oct 15, 2021

We are updating to AC library 2.10.0. PR #4074 is on its way.

@compulim
Copy link
Contributor

Status: Fixed

We bumped to Adaptive Cards 2.10 and it now support role="heading" for card headers.

image

image

@compulim compulim reopened this Oct 15, 2021
@kattepalli
Copy link

Verified issue at https://corinagum.github.io/WebChat-release-testing/02.babel-standalone/index.html URL and now heading level 2 is defined for all the cards. Hence the issue is fixed, closed the bug
Heading level defined
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
3 participants