Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Requirement - Bot Webchat - Home]: Luminosity ratio of Keyboard visual focus indicator for 'upload file' and 'send' buttons is less than 3:1. #4028

Closed
KattaBhargav opened this issue Aug 16, 2021 · 8 comments · Fixed by #4035
Assignees
Labels
Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 area-accessibility bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport exempt from daily DRI report
Milestone

Comments

@KattaBhargav
Copy link

KattaBhargav commented Aug 16, 2021

User Experience:
If the luminosity ratio of keyboard visual focus indicator is less than 3:1 for controls, then it can confuse the user having visual impairment to identify the control in low vision.

Repro Steps:

  1. Open URL: https://microsoft.github.io/BotFramework-WebChat/05.custom-components/l.disable-adaptive-cards/
  2. Page with Bot opens, Follow the dialog on this bot, and test the Adaptive Cards at the end of the dialog
  3. Check and verify that step 2 is accessible and MAS compliant.

Actual Result:
Luminosity ratio of Keyboard visual focus indicator for 'upload file' and 'send' buttons is less than 3:1.

Expected Result:
Luminosity ratio of Keyboard visual focus indicator for 'upload file' and 'send' buttons should be equal or greater than 3:1.

MAS Reference:
WCAG1.4.11 – Non-text Contrast

Test Environment:
OS: Win 10 21H1
Build: OS Build 19043.1147
Browser: Edge Chromium Version 94.0.972.2 (Official build) dev (64-bit)
#URL: https://microsoft.github.io/BotFramework-WebChat/05.custom-components/l.disable-adaptive-cards/

@KattaBhargav KattaBhargav added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Aug 16, 2021
@KattaBhargav
Copy link
Author

KattaBhargav commented Aug 16, 2021

#A11yMAS;#A11ySev2;#HCL;#WCAG1.4.11;#Accessibility;#Win10-Edge(Chromium);#BotFrameworkWebChat-Aug21;#A11yWCAG2.1;#Closed;#Regression;

@joshgummersall joshgummersall removed customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Aug 16, 2021
@cwhitten cwhitten added the ExemptFromDailyDRIReport exempt from daily DRI report label Aug 16, 2021
@compulim compulim removed their assignment Aug 16, 2021
@compulim compulim added this to the R15 milestone Aug 23, 2021
@compulim
Copy link
Contributor

Agree this need to be fixed.

Seems dupe of #4014. If yes, please close one of them, otherwise, can you describe differences between these two bugs?

@compulim
Copy link
Contributor

compulim commented Sep 2, 2021

After discuss with our design team, we will update the style of the upload/send button to more aligned with Fluent UI Icon Button, particularly:

  • When focus via keyboard (:focus-visible), will add a 1px dark border
  • On mouse hover, will have a light-dim background
  • When clicked (both keyboard or mouse), will have a dim background

Note :focus-visible is not available on IE11 and the WCIG polyfill would bring too much pollution. We need to write a new hook. We have one in the work for another accessibility issues and it need to be expanded for this work.

@compulim compulim self-assigned this Sep 13, 2021
@compulim
Copy link
Contributor

Copying style from Fluent UI.

image

image

image

Normal styles.

image

Styles for :hover and :active.

image

Styles for :focus-visible.

image

@compulim
Copy link
Contributor

I am keeping this open but resolved.

@compulim compulim reopened this Sep 22, 2021
@compulim compulim added the Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 label Sep 27, 2021
@compulim
Copy link
Contributor

compulim commented Sep 27, 2021

Status: Fixed

We have fixed this in PR #4035. Here is the quick demo after the fix.

recording (28)

@v-shikch
Copy link

It seems as a duplicate issue of above mentioned bug of #4014. Hence closing this bug will further track with the linked dup bug

@compulim
Copy link
Contributor

Thanks @v-shikch and @KattaBhargav. Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 area-accessibility bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport exempt from daily DRI report
Projects
None yet
5 participants