Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support image beside button text in Hero card #4117

Open
saikumaru opened this issue Jan 24, 2022 · 2 comments
Open

Support image beside button text in Hero card #4117

saikumaru opened this issue Jan 24, 2022 · 2 comments
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. external-adaptive-cards feature-request Azure report label

Comments

@saikumaru
Copy link

Please view our Technical Support Guide before filing a new issue.

Feature Request

Currently, this feature is supported for Suggested actions, as mentioned here
#1739

However the same feature is not supported on Hero card.
microsoft/botframework-sdk#2232

Currently cardAction does have a field for image,
https://docs.microsoft.com/en-us/javascript/api/botframework-schema/cardaction?view=botbuilder-ts-latest#properties
And also Herocard does support cardActions.
https://docs.microsoft.com/en-us/javascript/api/botframework-schema/herocard?view=botbuilder-ts-latest#botframework-schema-herocard-buttons

However this is not rendered on UI.

Is your feature request related to a problem? Please describe.
Yes, this limits the usage of herocards

Describe the suggestion or request in detail
Please provide the feature for client side script to render this image

Describe alternatives you have considered

This limits the way user menu is rendered to user. Suggested icons are sticky to the chat widget, and sometimes occupy lot of screen space, especially when the buttons are dynamically populated for a tabular rendering.

Additional context

@saikumaru saikumaru added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. feature-request Azure report label labels Jan 24, 2022
@compulim
Copy link
Contributor

compulim commented Oct 3, 2022

Thanks for looking into this.

Currently, we render rich card using Adaptive Cards. Although it does support iconUrl in its Action.Submit element, it does not support alt text. That means, if we support rendering the icon, we will fail accessibility audit.

When Adaptive Cards resolved their issue, then we can start supporting image/icon in hero cards.

@saikumaru
Copy link
Author

Thank you @compulim , really appreciate your direction of thought. I always thought Hero cards were a seperate functionality to adaptive cards. But probably can only wait now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. external-adaptive-cards feature-request Azure report label
Projects
None yet
Development

No branches or pull requests

2 participants