Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code related to activity middleware #4365

Open
compulim opened this issue Jul 29, 2022 · 0 comments
Open

Remove deprecated code related to activity middleware #4365

compulim opened this issue Jul 29, 2022 · 0 comments
Labels
feature-request Azure report label

Comments

@compulim
Copy link
Contributor

compulim commented Jul 29, 2022

(This is a continuation work of #4362)

Feature Request

activityRenderer, activityStatusRenderer, and attachmentRenderer props

The deprecation period of activityRenderer, activityStatusRenderer, and attachmentRenderer props is up on 2022-06-15. We should remove them to simplify our code.

nextVisibleActivity

The deprecation period of nextVisibleActivity is up on 2022-07-22. We should remove nextVisibleActivity to simplify our code.

While removing the nextVisibleActivity, also clean up some of our samples to make sure:

() => next => ({ activity, nextVisibleActivity }) => {
  return next({ activity, nextVisibleActivity });
}

To become:

() => next => (...args) => {
  return next(...args);
}

This clean up make sure activity middleware is upgradeable.

Move to freezeArray from Object.freeze() for some typed arrays

With the ordinary Object.freeze, it types out as by generalizing types for all items.

Object.freeze(['abc', 123]); // (number | string)[]

With freezeArray, it does not generalize types for all items.

freezeArray(['abc', 123]); // [string, number]

[feature-request]

@compulim compulim added customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. feature-request Azure report label and removed customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Jul 29, 2022
@compulim compulim changed the title Remove deprecated nextVisibleActivity from activity middleware Remove deprecated code related to activity middleware Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Azure report label
Projects
None yet
Development

No branches or pull requests

1 participant