Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Programmatic Access - Bot Framework Web chat - Carousel]: Headings are not proper on the page. Multiple h1's are defined on carousel response article. #4726

Closed
pgopinadhu opened this issue May 10, 2023 · 3 comments · Fixed by #4747
Assignees
Labels
area-accessibility blocked currently prevented from making progress bug Indicates an unexpected problem or an unintended behavior.

Comments

@pgopinadhu
Copy link

User Experience:

Screen reader users gets affected as they cannot understand the page structure if multiple h1 heading are defined on the page. Screen reader users cannot understand the heading hierarchy and cannot navigate effectively.

Note:

User credentials should NOT be included in the bug.

Repro Steps:

  • Launch URL: https://microsoft.github.io/BotFramework-WebChat/01.getting-started/a.full-bundle/ on edge dev.
  • Web chat page opens.
  • Press 4-tab keys to reach 'Type your message' field. Enter the "Carousel" keyword on it. Press 1-tab key to reach the 'send' button and activate it with the enter key.
  • Press 2-shift tabs and 1-down arrow to reach the received card. Activate it with the enter key. Focus lands on 'mark it down' link. Turn on AI-headings.
  • Verify whether the headings are properly defined or not.

Actual Result:

Headings are not proper on the page. Multiple h1's are defined on carousel response article.
Observation:
There is no main heading. H1 is defined for each tile/ card of the carousel response article.

Expected Result:

Headings hierarchy should be proper on the page. Multiple h1's should not be defined on carousel response article.
H1 should be defined for main content of page. Tile/ card headings should be defined as h2's.

MAS Reference:_

MAS 1.3.1 – Info and Relationships

Reference Links:

  • Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
  • External Bug Process: If this bug belongs to external team, mark it as resolved/done and assign it back to the tester with notes on where to file/route the bug. For more information, please use this Link. “HCL Staff should not log any third-party external bugs. Should be routed to edad team”.
  • Please reach out to C&AI Teams channel for any process related queries.

Test Environment:

OS: Windows 11 Enterprise 22H2 (OS build: 22621.1555)
Browser: Edge Version 114.0.1807.6 (Official build) dev (64-bit)
URL: Web Chat: Full-featured bundle (microsoft.github.io)
Tools: Developer Tool, Accessibility Insights for Web
Matrix: Edge dev+ Narrator.

@pgopinadhu
Copy link
Author

#A11yMAS;#A11ySev3;#MAS1.3.1;#AILimited;#HCL;#Accessibility;#Benchmark;#Win11-Edge(Chromium);

@compulim compulim self-assigned this Jun 14, 2023
@compulim
Copy link
Contributor

compulim commented Jun 14, 2023

Particularly.

image

From #4329, we are using undocumented ACHostConfig.textBlock.headingLevel to set it to 1. We probably want to set it to 2.

@compulim compulim added area-accessibility bug Indicates an unexpected problem or an unintended behavior. blocked currently prevented from making progress labels Jun 15, 2023
@compulim
Copy link
Contributor

Fixed by #4747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility blocked currently prevented from making progress bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants