ChakraCore servicing update for August, 2019 #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the loop prepass the index variable is not fully constructed, so we can't rely it being negative So we need to kiil the object type.
wyrichte
changed the title
zenparsing
reviewed
Aug 13, 2019
array.slice converts the native array to var array which was not captured during the optimization. Due to that the native array type is forced to var array which leads to the type confusion. Fixed this by killing the object type for the slice (as well as concat)
During GetChildren phase when we try to build JSON object we might throw exception. That skipped calling .Detach on the AutoPtr - which leads to release the debugger property again. Fixed that by catching and discarding the exception.
wyrichte
force-pushed
the
gh_servicing_1908
branch
from
a65cff7
to
450a349
Compare
pleath
approved these changes
Aug 13, 2019
MikeHolman
approved these changes
Aug 13, 2019
boingoing
approved these changes
Aug 13, 2019
chakrabot
pushed a commit
that referenced
this pull request
Aug 13, 2019
Merge pull request #6243 from wyrichte:gh_servicing_1908 This release addresses the following issues: CVE-2019-1197 CVE-2019-1141 CVE-2019-1196 CVE-2019-1139 CVE-2019-1131 CVE-2019-1195
chakrabot
pushed a commit
that referenced
this pull request
Aug 14, 2019
… August, 2019 Merge pull request #6243 from wyrichte:gh_servicing_1908 This release addresses the following issues: CVE-2019-1197 CVE-2019-1141 CVE-2019-1196 CVE-2019-1139 CVE-2019-1131 CVE-2019-1195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release addresses the following issues:
CVE-2019-1197
CVE-2019-1141
CVE-2019-1196
CVE-2019-1139
CVE-2019-1131
CVE-2019-1195