Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-tools): Support pnpm-workspace.yaml as workspace source #12252

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 4, 2022

fluid-build loads workspaces from lerna.json or package.json. This change adds support for pnpm's pnpm-workspace.yaml. Versions will still be loaded from lerna.json, but the workspace definition will be loaded from pnpm-workspace.yaml if it's present.

This is a quality of life fix for folks who are experimenting with pnpm in parts of the repo.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 4, 2022
@tylerbutler tylerbutler marked this pull request as ready for review October 4, 2022 22:42
@tylerbutler tylerbutler changed the title [fluid-build] Support pnpm-workspace.yaml feat(build-tools): Support pnpm-workspace.yaml as workspace source Oct 5, 2022
@tylerbutler tylerbutler merged commit 45c9f4f into microsoft:main Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

@tylerbutler tylerbutler deleted the fluid-build/pnpm branch October 11, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants