Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-tools): Add conventional commits deps and helper script #12261

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 5, 2022

Conventional commits help us automate changelog generation and generally make the commit log more useful. This PR adds dependencies and configuration for commitizen and commitlint to the build-tools release group.

Commitizen provides an interactive prompt to select the type of change and walks through the process step by step.

Commitlint, on the other hand, checks the resulting commit message before it's committed. These configurations are important as groundwork for CI enforcement, too.

Finally, I added a script to the root build-tools project that invokes commitizen. Now you can OPTIONALLY use npm run commit to commit a build-tools change with a compliant commit message.

IMPORTANT: this PR does not add checks in CI or any enforcement. This change is only helpful if people choose to use it. A future PR will add enforcement in CI.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 5, 2022
@tylerbutler tylerbutler marked this pull request as ready for review October 5, 2022 18:43
build-tools/package.json Outdated Show resolved Hide resolved
@tylerbutler tylerbutler merged commit e7c61a0 into microsoft:main Oct 6, 2022
@tylerbutler tylerbutler deleted the build-tools/commitlint branch October 6, 2022 02:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants