Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(policy-check): Make check policy continue after errors #12373

Merged
merged 3 commits into from
Oct 11, 2022
Merged

fix(policy-check): Make check policy continue after errors #12373

merged 3 commits into from
Oct 11, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 10, 2022 •
edited
Loading

The check policy command was not working properly. I think the primary problem was calls to this.exit(1) inside routeToHandlers, which made the process exit instead of continuing to process other handlers.

This change fixes the problem.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 10, 2022
@tylerbutler tylerbutler marked this pull request as ready for review October 10, 2022 23:09
@tylerbutler tylerbutler requested a review from a team as a code owner October 10, 2022 23:09
@tylerbutler tylerbutler merged commit edb1d84 into microsoft:main Oct 11, 2022
@tylerbutler tylerbutler deleted the cli/policy-fix branch October 11, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalivdeshpande sonalivdeshpande sonalivdeshpande approved these changes

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerbutler @sonalivdeshpande