fix(build-cli): Require versionConstraint flag in generate:typetests #12582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssimic2
reviewed
Oct 19, 2022
| @@ -63,7 +62,7 @@ export default class GenerateTypeTestsCommand extends BaseCommand< | |||
| "baseMinor", | |||
| "baseMajor", | |||
| ], | |||
| default: "baseMinor", | |||
| required: true, | |||
There was a problem hiding this comment.
I like this change. We discussed some of the reasoning on the other PR.
ssimic2
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generate:typetests command was incorrectly calculating the previous version when running in generate only mode. There was also not a way to indicate what version style to use, since the flag was exclusive with the
--generateflag.This change makes the
-sflag required, so the user has to choose a style explicitly.