fix(build-cli): Add baseline version and normalize JSON #12682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The baseline version is the previous minor/major released version? |
sonalivdeshpande
approved these changes
Oct 26, 2022
It's based on what's provided when the typetests command is run. The baseline version may differ based on the branch in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the typetests command to add the baseline version as a property in the typetests node of package.json. The baseline version is helpful information and previously you had to parse it out of the *-previous dependency string.
This change also always appends a trailing newline when writing JSON files, which is consistent with our repo settings.