Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build-cli): Read layer config file without using require() #12689

Merged
merged 4 commits into from
Oct 27, 2022
Merged

fix(build-cli): Read layer config file without using require() #12689

merged 4 commits into from
Oct 27, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 26, 2022 •
edited
Loading

Fixes the following issues with the check layers command:

  1. Replace use of require for JSON files with filesystem APIs.
  2. --md flag no longer has a default, so the command no longer outputs the markdown file all the time.
  3. --info is now a required flag.

BREAKING CHANGE: The --info flag is now required.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 26, 2022
@tylerbutler tylerbutler marked this pull request as ready for review October 26, 2022 22:16
@tylerbutler tylerbutler requested a review from a team as a code owner October 26, 2022 22:16
@tylerbutler tylerbutler merged commit 712016f into microsoft:main Oct 27, 2022
@tylerbutler tylerbutler deleted the cli/layer-fix branch October 27, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalivdeshpande sonalivdeshpande sonalivdeshpande approved these changes

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerbutler @sonalivdeshpande