fix(version-tools): Relax handling of internal dev/prerelease versions #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josmithr
approved these changes
Oct 28, 2022
tylerbutler
added a commit
that referenced
this pull request
Oct 31, 2022
…ons (#12734) Some necessary changes were missing from #12721 that made it incomplete. This PR includes those changes, which should address that PR's goals of accommodating versions that have more than 4 prerelease sections and versions that use a non-internal prerelease identifier. Prior to this change, versions like 2.0.0-dev.2.1.0.104436, which is set in our CI pipeline, would cause a build failure.
alexvy86
pushed a commit
to alexvy86/FluidFramework
that referenced
this pull request
Nov 1, 2022
microsoft#12721) Further relaxes the "rules" around the Fluid internal version scheme. This change should accommodate versions that have more than 4 prerelease sections and versions that use a non-internal prerelease identifier. Prior to this change, versions like `2.0.0-dev.2.1.0.104436`, which is set in our CI pipeline, would cause a build failure.
alexvy86
pushed a commit
to alexvy86/FluidFramework
that referenced
this pull request
Nov 1, 2022
…ons (microsoft#12734) Some necessary changes were missing from microsoft#12721 that made it incomplete. This PR includes those changes, which should address that PR's goals of accommodating versions that have more than 4 prerelease sections and versions that use a non-internal prerelease identifier. Prior to this change, versions like 2.0.0-dev.2.1.0.104436, which is set in our CI pipeline, would cause a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further relaxes the "rules" around the Fluid internal version scheme. This change should accommodate versions that have more than 4 prerelease sections and versions that use a non-internal prerelease identifier.
Prior to this change, versions like
2.0.0-dev.2.1.0.104436, which is set in our CI pipeline, would cause a build failure.