fix(bump): Fix detection of version scheme for test builds #12758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some libraries we depend on, like typescript and eslint, recommend using tilde dependencies instead of caret because they do introduce breaking changes in minor versions. This change adds a policy handler to enforce it.
tylerbutler
commented
Nov 2, 2022
Comment on lines
+93
to
+98
| it("detects 0.0.0-105091-test is semver", () => { | ||
| const input = `0.0.0-105091-test`; | ||
| const expected = "semver"; | ||
| assert.strictEqual(detectVersionScheme(input), expected); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This test passes as expected with no code change. The bug was in the command logic.
curtisman
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test builds have a version set in CI of the form
0.0.0-12345-test, where12345is the CI build number. The bump command was parsing the version scheme from the original version of the package and didn't update it with the final new version after processing all the command arguments.