-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(release:report): Split release report commands #12850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR description mentions "flub release all": did you mean "flub release report all"? |
Yeah -- now it's |
iamgiolaga
reviewed
Nov 9, 2022
iamgiolaga
reviewed
Nov 9, 2022
iamgiolaga
reviewed
Nov 9, 2022
iamgiolaga
reviewed
Nov 9, 2022
iamgiolaga
reviewed
Nov 9, 2022
iamgiolaga
reviewed
Nov 9, 2022
dannimad
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
release report
command arguments were confusing, especially after the--all
flag was added. This PR refactors therelease report
command into two separate commands,release report
andrelease history
.flub release report
is run for a single release group (i.e.flub release report -g azure
), the specified release group's version will be loaded from the repo, and its immediate Fluid dependencies will be included in the report. This is useful when we do a client or azure release and we want to include the dependency versions that the release group depends on.--interactive
flag.flub release history
replacesflub release report --all
. It will output a list of all releases for a single release group when the--releaseGroup
flag is passed. The number of releases shown can be limited using the--limit
flag.BREAKING CHANGE: The
--all
and--limit
flags have been removed fromflub release report
. Useflub release history
instead.Note for reviewers:
As implemented, in order to report on a specific version of a release group and follow its dependencies, you must check out the version of the repo at that release. For example, if you want to generate a report of the 1.1.1 client release and its dependencies, you would first check out the release tag:
git checkout client_v1.1.1
then runflub release report -g client -o <PATH>
.