Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(release:report): Split release report commands #12850

Merged
merged 24 commits into from
Nov 16, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Nov 8, 2022

The release report command arguments were confusing, especially after the --all flag was added. This PR refactors the release report command into two separate commands, release report and release history.

  • When flub release report is run for a single release group (i.e. flub release report -g azure), the specified release group's version will be loaded from the repo, and its immediate Fluid dependencies will be included in the report. This is useful when we do a client or azure release and we want to include the dependency versions that the release group depends on.
  • To run the previous default mode where you interactively choose each release, pass the --interactive flag.
  • flub release history replaces flub release report --all. It will output a list of all releases for a single release group when the --releaseGroup flag is passed. The number of releases shown can be limited using the --limit flag.

BREAKING CHANGE: The --all and --limit flags have been removed from flub release report. Use flub release history instead.


Note for reviewers:

As implemented, in order to report on a specific version of a release group and follow its dependencies, you must check out the version of the repo at that release. For example, if you want to generate a report of the 1.1.1 client release and its dependencies, you would first check out the release tag: git checkout client_v1.1.1 then run flub release report -g client -o <PATH>.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Nov 8, 2022
@tylerbutler tylerbutler marked this pull request as ready for review November 9, 2022 00:27
@tylerbutler tylerbutler requested a review from a team as a code owner November 9, 2022 00:27
@CraigMacomber
Copy link
Contributor

PR description mentions "flub release all": did you mean "flub release report all"?

@tylerbutler
Copy link
Member Author

PR description mentions "flub release all": did you mean "flub release report all"?

Yeah -- now it's flub release history.

@tylerbutler tylerbutler merged commit 0678fd2 into microsoft:main Nov 16, 2022
@tylerbutler tylerbutler deleted the cli/report-refactor branch November 16, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants