fix(fluid-build): Parse build-cli tasks properly in fluid-build #12988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
commented
Nov 17, 2022
tylerbutler
commented
Nov 17, 2022
Comment on lines
+19
to
+23
| toReturn = commands.slice(0, flagsStartIndex).join(" "); | ||
| } else { | ||
| toReturn = commands[0]; | ||
| } | ||
| return toReturn; |
There was a problem hiding this comment.
Suggested change
| toReturn = commands.slice(0, flagsStartIndex).join(" "); | |
| } else { | |
| toReturn = commands[0]; | |
| } | |
| return toReturn; | |
| return commands.slice(0, flagsStartIndex).join(" "); | |
| } else { | |
| return commands[0]; | |
| } |
Is this "better" in some objective way? Or is it just stylistic preferences?
There was a problem hiding this comment.
I like the modified way as it eliminates variable declaration 😄
sonalivdeshpande
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new build-cli requires a bit more parsing to decompose the task into fluid-build's build graph. This change updates the parsing method to handle flub correctly.
The former implementation assumed that the command executable was the first argument of the command, but that doesn't hold for commands with subcommands.
The changed implementation assumes flags come at the end of the command, and that all subsequent arguments are flags. All non-flag arguments are then assumed to be the executable name. This is true for most of the commands today (and all of the ones that fluid-build needs to understand), but it is somewhat fragile.