Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build-tools): Load workspaceGlobs from pnpm properly #13083

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix(build-tools): Load workspaceGlobs from pnpm properly #13083

merged 1 commit into from
Nov 28, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Nov 23, 2022 •
edited
Loading

The workspaceGlobs property wasn't being set when the package manager is pnpm.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Nov 23, 2022
@tylerbutler tylerbutler marked this pull request as ready for review November 23, 2022 19:06
@tylerbutler tylerbutler requested a review from a team as a code owner November 23, 2022 19:06
@tylerbutler tylerbutler merged commit 2f162b6 into microsoft:main Nov 28, 2022
@tylerbutler tylerbutler deleted the cli/workspace-globs branch November 28, 2022 18:57
@tylerbutler
Copy link
Member Author

Thanks for the review, @Josmithr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmithr Josmithr Josmithr approved these changes

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerbutler @Josmithr