Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Reduce duplication in Makevars.in, Makevars.win #3249

Closed
jameslamb opened this issue Jul 24, 2020 · 2 comments
Closed

[R-package] Reduce duplication in Makevars.in, Makevars.win #3249

jameslamb opened this issue Jul 24, 2020 · 2 comments

Comments

@jameslamb
Copy link
Collaborator

Summary

See #3188 (comment) for background. Today in R-package/Makevars.win.in and R-package/Makevars.in, all objects have to be explicitly listed out.

To close this issue, you might take an approach like what xgboost does: https://github.com/dmlc/xgboost/blob/master/amalgamation/xgboost-all0.cc

@jameslamb
Copy link
Collaborator Author

closed in favor of being in #2302 ,where we keep all feature requests. Please comment here if you'd like to contribute this and the issue will be re-opened.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant