Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about data processing in Unsupervised NMT #171

Open
ElliottYan opened this issue Nov 20, 2020 · 0 comments
Open

Question about data processing in Unsupervised NMT #171

ElliottYan opened this issue Nov 20, 2020 · 0 comments

Comments

@ElliottYan
Copy link

Hi, thanks for sharing your code.

I'm currently trying to reproduce your results on unsupervised NMT. I noted that you mentioned you filter out tokenized data with more than 175 tokens. However, I didn't find any code in your data processing file get-data-nmt.sh for doing so.

Can you confirm that the data script is up-to-date?

Also, I use the pretraining script you provided in some issues. I found that the loader in your code would remove long sequences, which is set to 100 sub-tokens for default.
Did you filter out the sequence longer than 175 tokens here?

Looking forward to your reply. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant